diff options
| author | Greg Kroah-Hartman <[email protected]> | 2020-09-23 20:48:03 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <[email protected]> | 2020-10-02 15:47:09 +0200 |
| commit | 44577f1d98545fff565df81793418e40eecc7394 (patch) | |
| tree | 5d991116b14e10f154a475e47f1afbd505fd5ded /tools/perf/scripts/python/Perf-Trace-Util/lib/Perf/Trace | |
| parent | 6284a6e8940341beb71ea7970388418eb3dd473d (diff) | |
platform/x86: intel_pmc_core: do not create a static struct device
A struct device is a dynamic structure, with reference counting.
"Tricking" the kernel to make a dynamic structure static, by working
around the driver core release detection logic, is not nice.
Because of this, this code has been used as an example for others on
"how to do things", which is just about the worst thing possible to have
happen.
Fix this all up by making the platform device dynamic and providing a
real release function.
Fixes: b02f6a2ef0a1 ("platform/x86: intel_pmc_core: Attach using APCI HID "INT33A1"")
Cc: Rajneesh Bhardwaj <[email protected]>
Cc: Vishwanath Somayaji <[email protected]>
Cc: Darren Hart <[email protected]>
Cc: Andy Shevchenko <[email protected]>
Reported-by: Maximilian Luz <[email protected]>
Reviewed-by: Hans de Goede <[email protected]>
Acked-by: Rajat Jain <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/Perf-Trace-Util/lib/Perf/Trace')
0 files changed, 0 insertions, 0 deletions