diff options
author | Justin Stitt <[email protected]> | 2023-08-24 18:52:18 +0000 |
---|---|---|
committer | Ingo Molnar <[email protected]> | 2023-08-24 21:22:06 +0200 |
commit | 1e6f01f7285559a5302e85677b8e59a5de9b0ea5 (patch) | |
tree | ebf3313eff6c8baea7dd10ac222b9af5afdf87d8 /tools/perf/scripts/python/Perf-Trace-Util/Build | |
parent | 8874a414f8f706daf1de467cbf2550988ebec09d (diff) |
x86/platform/uv: Refactor code using deprecated strcpy()/strncpy() interfaces to use strscpy()
Both `strncpy` and `strcpy` are deprecated for use on NUL-terminated
destination strings [1].
A suitable replacement is `strscpy` [2] due to the fact that it
guarantees NUL-termination on its destination buffer argument which is
_not_ the case for `strncpy` or `strcpy`!
In this case, we can drop both the forced NUL-termination and the `... -1` from:
| strncpy(arg, val, ACTION_LEN - 1);
as `strscpy` implicitly has this behavior.
Also include slight refactor to code removing possible new-line chars as
per Yang Yang's work at [3]. This reduces code size and complexity by
using more robust and better understood interfaces.
Co-developed-by: Yang Yang <[email protected]>
Signed-off-by: Justin Stitt <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>
Cc: Andy Shevchenko <[email protected]>
Cc: Kees Cook <[email protected]>
Cc: Dimitri Sivanich <[email protected]>
Link: www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings[1]
Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2]
Link: https://lore.kernel.org/all/[email protected]/ [3]
Link: https://github.com/KSPP/linux/issues/90
Link: https://lore.kernel.org/r/20230824-strncpy-arch-x86-platform-uv-uv_nmi-v2-1-e16d9a3ec570@google.com
Signed-off-by: Ingo Molnar <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/Perf-Trace-Util/Build')
0 files changed, 0 insertions, 0 deletions