diff options
author | Alexey Gladkov <[email protected]> | 2023-05-17 11:49:46 +0200 |
---|---|---|
committer | Daniel Borkmann <[email protected]> | 2023-05-17 15:43:32 +0200 |
commit | f04a32b2c5b539e3c097cb5c7c1df12a8f4a0cf0 (patch) | |
tree | cc9cadfad2ee178c2a016fdcf37ac86b6dddf663 /tools/bpf/bpftool/common.c | |
parent | cff36398bd4c7d322d424433db437f3c3391c491 (diff) |
selftests/bpf: Do not use sign-file as testcase
The sign-file utility (from scripts/) is used in prog_tests/verify_pkcs7_sig.c,
but the utility should not be called as a test. Executing this utility produces
the following error:
selftests: /linux/tools/testing/selftests/bpf: urandom_read
ok 16 selftests: /linux/tools/testing/selftests/bpf: urandom_read
selftests: /linux/tools/testing/selftests/bpf: sign-file
not ok 17 selftests: /linux/tools/testing/selftests/bpf: sign-file # exit=2
Also, urandom_read is mistakenly used as a test. It does not lead to an error,
but should be moved over to TEST_GEN_FILES as well. The empty TEST_CUSTOM_PROGS
can then be removed.
Fixes: fc97590668ae ("selftests/bpf: Add test for bpf_verify_pkcs7_signature() kfunc")
Signed-off-by: Alexey Gladkov <[email protected]>
Signed-off-by: Daniel Borkmann <[email protected]>
Reviewed-by: Roberto Sassu <[email protected]>
Acked-by: Stanislav Fomichev <[email protected]>
Link: https://lore.kernel.org/bpf/[email protected]
Link: https://lore.kernel.org/bpf/88e3ab23029d726a2703adcf6af8356f7a2d3483.1684316821.git.legion@kernel.org
Diffstat (limited to 'tools/bpf/bpftool/common.c')
0 files changed, 0 insertions, 0 deletions