aboutsummaryrefslogtreecommitdiff
path: root/scripts/stackusage
diff options
context:
space:
mode:
authorZhao Hongjiang <[email protected]>2013-04-30 15:26:46 -0700
committerLinus Torvalds <[email protected]>2013-04-30 17:04:00 -0700
commit04df32fa10ab9a6f0643db2949d42efc966bc844 (patch)
tree48cdb596da6d4b8bd49c743b570b63b936eba34f /scripts/stackusage
parentace6128d603d3f15238baba104d0b37ccf0b6c07 (diff)
inotify: invalid mask should return a error number but not set it
When we run the crackerjack testsuite, the inotify_add_watch test is stalled. This is caused by the invalid mask 0 - the task is waiting for the event but it never comes. inotify_add_watch() should return -EINVAL as it did before commit 676a0675cf92 ("inotify: remove broken mask checks causing unmount to be EINVAL"). That commit removes the invalid mask check, but that check is needed. Check the mask's ALL_INOTIFY_BITS before the inotify_arg_to_mask() call. If none are set, just return -EINVAL. Because IN_UNMOUNT is in ALL_INOTIFY_BITS, this change will not trigger the problem that above commit fixed. [[email protected]: fix build] Signed-off-by: Zhao Hongjiang <[email protected]> Acked-by: Jim Somerville <[email protected]> Cc: Paul Gortmaker <[email protected]> Cc: Jerome Marchand <[email protected]> Cc: Eric Paris <[email protected]> Cc: <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
Diffstat (limited to 'scripts/stackusage')
0 files changed, 0 insertions, 0 deletions