diff options
author | Ming Lei <ming.lei@redhat.com> | 2023-07-11 17:40:40 +0800 |
---|---|---|
committer | Keith Busch <kbusch@kernel.org> | 2023-07-21 00:53:29 -0700 |
commit | 99dc264014d5aed66ee37ddf136a38b5a2b1b529 (patch) | |
tree | 83f1fca9acbe6ec5decd6a5341a597e6bdfa272e /scripts/rustdoc_test_builder.rs | |
parent | 1b95e817916069ec45a7f259d088fd1c091a8cc6 (diff) |
nvme-tcp: fix potential unbalanced freeze & unfreeze
Move start_freeze into nvme_tcp_configure_io_queues(), and there is
at least two benefits:
1) fix unbalanced freeze and unfreeze, since re-connection work may
fail or be broken by removal
2) IO during error recovery can be failfast quickly because nvme fabrics
unquiesces queues after teardown.
One side-effect is that !mpath request may timeout during connecting
because of queue topo change, but that looks not one big deal:
1) same problem exists with current code base
2) compared with !mpath, mpath use case is dominant
Fixes: 2875b0aecabe ("nvme-tcp: fix controller reset hang during traffic")
Cc: stable@vger.kernel.org
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Tested-by: Yi Zhang <yi.zhang@redhat.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Keith Busch <kbusch@kernel.org>
Diffstat (limited to 'scripts/rustdoc_test_builder.rs')
0 files changed, 0 insertions, 0 deletions