diff options
| author | Matthieu Baerts (NGI0) <[email protected]> | 2024-08-19 21:45:27 +0200 |
|---|---|---|
| committer | Jakub Kicinski <[email protected]> | 2024-08-20 17:40:13 -0700 |
| commit | 1c1f721375989579e46741f59523e39ec9b2a9bd (patch) | |
| tree | 2444bbe7fab7abad9a47801f61a7f6bc69cb65f4 /scripts/rustdoc_test_builder.rs | |
| parent | 322ea3778965da72862cca2a0c50253aacf65fe6 (diff) | |
mptcp: pm: only decrement add_addr_accepted for MPJ req
Adding the following warning ...
WARN_ON_ONCE(msk->pm.add_addr_accepted == 0)
... before decrementing the add_addr_accepted counter helped to find a
bug when running the "remove single subflow" subtest from the
mptcp_join.sh selftest.
Removing a 'subflow' endpoint will first trigger a RM_ADDR, then the
subflow closure. Before this patch, and upon the reception of the
RM_ADDR, the other peer will then try to decrement this
add_addr_accepted. That's not correct because the attached subflows have
not been created upon the reception of an ADD_ADDR.
A way to solve that is to decrement the counter only if the attached
subflow was an MP_JOIN to a remote id that was not 0, and initiated by
the host receiving the RM_ADDR.
Fixes: d0876b2284cf ("mptcp: add the incoming RM_ADDR support")
Cc: [email protected]
Reviewed-by: Mat Martineau <[email protected]>
Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>
Diffstat (limited to 'scripts/rustdoc_test_builder.rs')
0 files changed, 0 insertions, 0 deletions