diff options
author | Heng Qi <hengqi@linux.alibaba.com> | 2023-10-08 14:27:39 +0800 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2023-10-11 07:13:50 +0100 |
commit | 3014a0d54820d25c3dc66657bcc19013f2338760 (patch) | |
tree | 06137282149134a11ad7322e7b78dec8a5eb48ff /scripts/mkuboot.sh | |
parent | e5f061d5e340fefc663cacfe8f42f149d55bdb53 (diff) |
virtio-net: initially change the value of tx-frames
Background:
1. Commit 0c465be183c7 ("virtio_net: ethtool tx napi configuration") uses
tx-frames to toggle napi_tx (0 off and 1 on) if notification coalescing
is not supported.
2. Commit 31c03aef9bc2 ("virtio_net: enable napi_tx by default") enables
napi_tx for all txqs by default.
Status:
When virtio-net supports notification coalescing, after initialization,
tx-frames is 0 and napi_tx is true.
Problem:
When the user only wants to set rx coalescing params using
ethtool -C eth0 rx-usecs 10, or
ethtool -Q eth0 queue_mask 0x1 -C rx-usecs 10,
these cmds will carry tx-frames as 0, causing the napi_tx switching condition
is satisfied. Then the user gets:
netlink error: Device or resource busy.
The same happens when trying to set rx-frames, adaptive_rx, adaptive_tx...
How to fix:
When notification coalescing feature is negotiated, initially make the
value of tx-frames to be consistent with napi_tx.
For compatibility with the past, it is still supported to use tx-frames
to toggle napi_tx.
Reported-by: Xiaoming Zhao <zxm377917@alibaba-inc.com>
Signed-off-by: Heng Qi <hengqi@linux.alibaba.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'scripts/mkuboot.sh')
0 files changed, 0 insertions, 0 deletions