diff options
author | Kurt Kanzenbach <[email protected]> | 2024-02-25 12:38:37 +0100 |
---|---|---|
committer | Jakub Kicinski <[email protected]> | 2024-02-27 18:17:47 -0800 |
commit | f72a1994698ebe1a9eeadba7bfe2aa01afcde0a4 (patch) | |
tree | 408c8344dcaab8d530bf7b859876cdb2e942a83b /scripts/generate_rust_analyzer.py | |
parent | c68b2c9eba38ec3f60f4894b189090febf4d8d22 (diff) |
net: stmmac: Complete meta data only when enabled
Currently using plain XDP/ZC sockets on stmmac results in a kernel crash:
|[ 255.822584] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000
|[...]
|[ 255.822764] Call trace:
|[ 255.822766] stmmac_tx_clean.constprop.0+0x848/0xc38
The program counter indicates xsk_tx_metadata_complete(). It works on
compl->tx_timestamp, which is not set by xsk_tx_metadata_to_compl() due to
missing meta data. Therefore, call xsk_tx_metadata_complete() only when
meta data is actually used.
Tested on imx93 without XDP, with XDP and with XDP/ZC.
Fixes: 1347b419318d ("net: stmmac: Add Tx HWTS support to XDP ZC")
Suggested-by: Serge Semin <[email protected]>
Tested-by: Serge Semin <[email protected]>
Link: https://lore.kernel.org/netdev/[email protected]/
Acked-by: Stanislav Fomichev <[email protected]>
Signed-off-by: Kurt Kanzenbach <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>
Diffstat (limited to 'scripts/generate_rust_analyzer.py')
0 files changed, 0 insertions, 0 deletions