diff options
| author | Bart Van Assche <[email protected]> | 2023-08-23 13:57:27 -0700 |
|---|---|---|
| committer | Leon Romanovsky <[email protected]> | 2023-09-11 14:15:58 +0300 |
| commit | e193b7955dfad68035b983a0011f4ef3590c85eb (patch) | |
| tree | 2adc3b6fdba65fe243d0f41c2c0a5576d37dcef5 /scripts/generate_rust_analyzer.py | |
| parent | 0bb80ecc33a8fb5a682236443c1e740d5c917d1d (diff) | |
RDMA/srp: Do not call scsi_done() from srp_abort()
After scmd_eh_abort_handler() has called the SCSI LLD eh_abort_handler
callback, it performs one of the following actions:
* Call scsi_queue_insert().
* Call scsi_finish_command().
* Call scsi_eh_scmd_add().
Hence, SCSI abort handlers must not call scsi_done(). Otherwise all
the above actions would trigger a use-after-free. Hence remove the
scsi_done() call from srp_abort(). Keep the srp_free_req() call
before returning SUCCESS because we may not see the command again if
SUCCESS is returned.
Cc: Bob Pearson <[email protected]>
Cc: Shinichiro Kawasaki <[email protected]>
Fixes: d8536670916a ("IB/srp: Avoid having aborted requests hang")
Signed-off-by: Bart Van Assche <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Leon Romanovsky <[email protected]>
Diffstat (limited to 'scripts/generate_rust_analyzer.py')
0 files changed, 0 insertions, 0 deletions