diff options
author | Paolo Abeni <[email protected]> | 2023-03-09 15:50:04 +0100 |
---|---|---|
committer | Jakub Kicinski <[email protected]> | 2023-03-10 21:42:56 -0800 |
commit | cee4034a3db1d30c3243dd51506a9d4ab1a849fa (patch) | |
tree | ffd410e1124391f1527773d9d5d762391f14ca5a /scripts/generate_rust_analyzer.py | |
parent | 3ba14528684f528566fb7d956bfbfb958b591d86 (diff) |
mptcp: fix lockdep false positive in mptcp_pm_nl_create_listen_socket()
Christoph reports a lockdep splat in the mptcp_subflow_create_socket()
error path, when such function is invoked by
mptcp_pm_nl_create_listen_socket().
Such code path acquires two separates, nested socket lock, with the
internal lock operation lacking the "nested" annotation. Adding that
in sock_release() for mptcp's sake only could be confusing.
Instead just add a new lockclass to the in-kernel msk socket,
re-initializing the lockdep infra after the socket creation.
Fixes: ad2171009d96 ("mptcp: fix locking for in-kernel listener creation")
Cc: [email protected]
Reported-by: Christoph Paasch <[email protected]>
Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/354
Signed-off-by: Paolo Abeni <[email protected]>
Reviewed-by: Matthieu Baerts <[email protected]>
Tested-by: Christoph Paasch <[email protected]>
Signed-off-by: Matthieu Baerts <[email protected]>
Signed-off-by: Jakub Kicinski <[email protected]>
Diffstat (limited to 'scripts/generate_rust_analyzer.py')
0 files changed, 0 insertions, 0 deletions