diff options
author | Paolo Abeni <[email protected]> | 2023-12-26 13:10:18 +0100 |
---|---|---|
committer | Jakub Kicinski <[email protected]> | 2024-01-02 16:12:47 -0800 |
commit | 4c0288299fd09ee7c6fbe2f57421f314d8c981db (patch) | |
tree | c7b846e65031b478531943f31beaf87da87d8aac /scripts/generate_rust_analyzer.py | |
parent | 118ba479d02c5a55e1c1d3c7a43de8937680e67d (diff) |
mptcp: prevent tcp diag from closing listener subflows
The MPTCP protocol does not expect that any other entity could change
the first subflow status when such socket is listening.
Unfortunately the TCP diag interface allows aborting any TCP socket,
including MPTCP listeners subflows. As reported by syzbot, that trigger
a WARN() and could lead to later bigger trouble.
The MPTCP protocol needs to do some MPTCP-level cleanup actions to
properly shutdown the listener. To keep the fix simple, prevent
entirely the diag interface from stopping such listeners.
We could refine the diag callback in a later, larger patch targeting
net-next.
Fixes: 57fc0f1ceaa4 ("mptcp: ensure listener is unhashed before updating the sk status")
Cc: [email protected]
Reported-by: <[email protected]>
Closes: https://lore.kernel.org/netdev/[email protected]/
Signed-off-by: Paolo Abeni <[email protected]>
Reviewed-by: Mat Martineau <[email protected]>
Signed-off-by: Matthieu Baerts <[email protected]>
Link: https://lore.kernel.org/r/20231226-upstream-net-20231226-mptcp-prevent-warn-v1-2-1404dcc431ea@kernel.org
Signed-off-by: Jakub Kicinski <[email protected]>
Diffstat (limited to 'scripts/generate_rust_analyzer.py')
0 files changed, 0 insertions, 0 deletions