diff options
| author | Eric Dumazet <[email protected]> | 2021-09-13 22:18:51 -0700 |
|---|---|---|
| committer | David S. Miller <[email protected]> | 2021-09-14 14:24:31 +0100 |
| commit | d198b27762644c71362e43a7533f89c92b115bcf (patch) | |
| tree | 7650f671289f847a7a157ce5c4d346bcf20d7cfd /scripts/gdb | |
| parent | 4f884f3962767877d7aabbc1ec124d2c307a4257 (diff) | |
Revert "Revert "ipv4: fix memory leaks in ip_cmsg_send() callers""
This reverts commit d7807a9adf4856171f8441f13078c33941df48ab.
As mentioned in https://lkml.org/lkml/2021/9/13/1819
5 years old commit 919483096bfe ("ipv4: fix memory leaks in ip_cmsg_send() callers")
was a correct fix.
ip_cmsg_send() can loop over multiple cmsghdr()
If IP_RETOPTS has been successful, but following cmsghdr generates an error,
we do not free ipc.ok
If IP_RETOPTS is not successful, we have freed the allocated temporary space,
not the one currently in ipc.opt.
Sure, code could be refactored, but let's not bring back old bugs.
Fixes: d7807a9adf48 ("Revert "ipv4: fix memory leaks in ip_cmsg_send() callers"")
Signed-off-by: Eric Dumazet <[email protected]>
Cc: Yajun Deng <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'scripts/gdb')
0 files changed, 0 insertions, 0 deletions