diff options
author | Ewan D. Milne <[email protected]> | 2021-10-29 15:43:10 -0400 |
---|---|---|
committer | Martin K. Petersen <[email protected]> | 2021-11-03 21:33:50 -0400 |
commit | 5ae17501bc62a49b0b193dcce003f16375f16654 (patch) | |
tree | 62c17bc18a2c76cae1b691dae9c9b9a41bb0783c /scripts/gdb/linux/utils.py | |
parent | 5f7cf82c1d7373fcf9e1062f5654efd5fa2b9211 (diff) |
scsi: core: Avoid leaving shost->last_reset with stale value if EH does not run
The changes to issue the abort from the scmd->abort_work instead of the EH
thread introduced a problem if eh_deadline is used. If aborting the
command(s) is successful, and there are never any scmds added to the
shost->eh_cmd_q, there is no code path which will reset the ->last_reset
value back to zero.
The effect of this is that after a successful abort with no EH thread
activity, a subsequent timeout, perhaps a long time later, might
immediately be considered past a user-set eh_deadline time, and the host
will be reset with no attempt at recovery.
Fix this by resetting ->last_reset back to zero in scmd_eh_abort_handler()
if it is determined that the EH thread will not run to do this.
Thanks to Gopinath Marappan for investigating this problem.
Link: https://lore.kernel.org/r/[email protected]
Fixes: e494f6a72839 ("[SCSI] improved eh timeout handler")
Cc: [email protected]
Signed-off-by: Ewan D. Milne <[email protected]>
Signed-off-by: Martin K. Petersen <[email protected]>
Diffstat (limited to 'scripts/gdb/linux/utils.py')
0 files changed, 0 insertions, 0 deletions