diff options
author | Qais Yousef <[email protected]> | 2021-05-10 15:50:32 +0100 |
---|---|---|
committer | Peter Zijlstra <[email protected]> | 2021-05-19 10:53:02 +0200 |
commit | 93b73858701fd01de26a4a874eb95f9b7156fd4b (patch) | |
tree | b32f97678796f331182efde3cf03a69683e02cba /scripts/gdb/linux/tasks.py | |
parent | 0c18f2ecfcc274a4bcc1d122f79ebd4001c3b445 (diff) |
sched/uclamp: Fix locking around cpu_util_update_eff()
cpu_cgroup_css_online() calls cpu_util_update_eff() without holding the
uclamp_mutex or rcu_read_lock() like other call sites, which is
a mistake.
The uclamp_mutex is required to protect against concurrent reads and
writes that could update the cgroup hierarchy.
The rcu_read_lock() is required to traverse the cgroup data structures
in cpu_util_update_eff().
Surround the caller with the required locks and add some asserts to
better document the dependency in cpu_util_update_eff().
Fixes: 7226017ad37a ("sched/uclamp: Fix a bug in propagating uclamp value in new cgroups")
Reported-by: Quentin Perret <[email protected]>
Signed-off-by: Qais Yousef <[email protected]>
Signed-off-by: Peter Zijlstra (Intel) <[email protected]>
Link: https://lkml.kernel.org/r/[email protected]
Diffstat (limited to 'scripts/gdb/linux/tasks.py')
0 files changed, 0 insertions, 0 deletions