diff options
author | Nicholas Piggin <[email protected]> | 2021-06-30 17:46:13 +1000 |
---|---|---|
committer | Michael Ellerman <[email protected]> | 2021-06-30 22:21:19 +1000 |
commit | 5567b1ee29b7a83e8c01d99d34b5bbd306ce0bcf (patch) | |
tree | 84e99a2e732cdaea3909ca3f922b44a523268fa4 /scripts/gdb/linux/tasks.py | |
parent | fc4999864bca323f1b844fefe1b402632443c076 (diff) |
powerpc/64s: fix hash page fault interrupt handler
The early bad fault or key fault test in do_hash_fault() ends up calling
into ___do_page_fault without having gone through an interrupt handler
wrapper (except the initial _RAW one). This can end up calling local irq
functions while the interrupt has not been reconciled, which will likely
cause crashes and it trips up on a later patch that adds more assertions.
pkey_exec_prot from selftests causes this path to be executed.
There is no real reason to run the in_nmi() test should be performed
before the key fault check. In fact if a perf interrupt in the hash
fault code did a stack walk that was made to take a key fault somehow
then running ___do_page_fault could possibly cause another hash fault
causing problems. Move the in_nmi() test first, and then do everything
else inside the regular interrupt handler function.
Fixes: 3a96570ffceb ("powerpc: convert interrupt handlers to use wrappers")
Reported-by: Sachin Sant <[email protected]>
Signed-off-by: Nicholas Piggin <[email protected]>
Tested-by: Sachin Sant <[email protected]>
Signed-off-by: Michael Ellerman <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Diffstat (limited to 'scripts/gdb/linux/tasks.py')
0 files changed, 0 insertions, 0 deletions