diff options
| author | Chengfeng Ye <[email protected]> | 2023-07-27 08:56:19 +0000 |
|---|---|---|
| committer | Jakub Kicinski <[email protected]> | 2023-07-28 18:49:28 -0700 |
| commit | 56c6be35fcbed54279df0a2c9e60480a61841d6f (patch) | |
| tree | 564a7db3134535851d269e567ba8ddec5e243a7c /scripts/gdb/linux/stackdepot.py | |
| parent | e68409db995380d1badacba41ff24996bd396171 (diff) | |
mISDN: hfcpci: Fix potential deadlock on &hc->lock
As &hc->lock is acquired by both timer _hfcpci_softirq() and hardirq
hfcpci_int(), the timer should disable irq before lock acquisition
otherwise deadlock could happen if the timmer is preemtped by the hadr irq.
Possible deadlock scenario:
hfcpci_softirq() (timer)
-> _hfcpci_softirq()
-> spin_lock(&hc->lock);
<irq interruption>
-> hfcpci_int()
-> spin_lock(&hc->lock); (deadlock here)
This flaw was found by an experimental static analysis tool I am developing
for irq-related deadlock.
The tentative patch fixes the potential deadlock by spin_lock_irq()
in timer.
Fixes: b36b654a7e82 ("mISDN: Create /sys/class/mISDN")
Signed-off-by: Chengfeng Ye <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>
Diffstat (limited to 'scripts/gdb/linux/stackdepot.py')
0 files changed, 0 insertions, 0 deletions