diff options
author | Peijie Shao <shaopeijie@cestc.cn> | 2023-05-23 10:45:36 +0800 |
---|---|---|
committer | Jarkko Sakkinen <jarkko@kernel.org> | 2023-07-17 19:32:30 +0000 |
commit | f0afba4042bd902d290405c0638bc1295872d8a7 (patch) | |
tree | fc85aba03a77a39840e803e33ccc56250d2772bc /scripts/gdb/linux/modules.py | |
parent | edb13d7bb034c4d5523f15e9aeea31c504af6f91 (diff) |
tpm_tis_spi: Release chip select when flow control fails
The failure paths in tpm_tis_spi_transfer() do not deactivate
chip select. Send an empty message (cs_select == 0) to overcome
this.
The patch is tested by two ways.
One way needs to touch hardware:
1. force pull MISO pin down to GND, it emulates a forever
'WAIT' timing.
2. probe cs pin by an oscilloscope.
3. load tpm_tis_spi.ko.
After loading, dmesg prints:
"probe of spi0.0 failed with error -110"
and oscilloscope shows cs pin goes high(deactivated) after
the failure. Before the patch, cs pin keeps low.
Second way is by writing a fake spi controller.
1. implement .transfer_one method, fill all rx buf with 0.
2. implement .set_cs method, print the state of cs pin.
we can see cs goes high after the failure.
Signed-off-by: Peijie Shao <shaopeijie@cestc.cn>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
Diffstat (limited to 'scripts/gdb/linux/modules.py')
0 files changed, 0 insertions, 0 deletions