diff options
author | Daniel Vetter <[email protected]> | 2023-04-12 17:31:46 +0200 |
---|---|---|
committer | Daniel Vetter <[email protected]> | 2023-04-13 20:10:11 +0200 |
commit | fffb0b52d5258554c645c966c6cbef7de50b851d (patch) | |
tree | ba200e418489a315f7bad0bdb47c5cecf10bc096 /scripts/gdb/linux/lists.py | |
parent | edf79dd2172233452ff142dcc98b19d955fc8974 (diff) |
fbcon: set_con2fb_map needs to set con2fb_map!
I got really badly confused in d443d9386472 ("fbcon: move more common
code into fb_open()") because we set the con2fb_map before the failure
points, which didn't look good.
But in trying to fix that I moved the assignment into the wrong path -
we need to do it for _all_ vc we take over, not just the first one
(which additionally requires the call to con2fb_acquire_newinfo).
I've figured this out because of a KASAN bug report, where the
fbcon_registered_fb and fbcon_display arrays went out of sync in
fbcon_mode_deleted() because the con2fb_map pointed at the old
fb_info, but the modes and everything was updated for the new one.
Signed-off-by: Daniel Vetter <[email protected]>
Reviewed-by: Javier Martinez Canillas <[email protected]>
Acked-by: Helge Deller <[email protected]>
Tested-by: Xingyuan Mo <[email protected]>
Fixes: d443d9386472 ("fbcon: move more common code into fb_open()")
Reported-by: Xingyuan Mo <[email protected]>
Cc: Thomas Zimmermann <[email protected]>
Cc: Sam Ravnborg <[email protected]>
Cc: Xingyuan Mo <[email protected]>
Cc: Thomas Zimmermann <[email protected]>
Cc: Helge Deller <[email protected]>
Cc: <[email protected]> # v5.19+
Diffstat (limited to 'scripts/gdb/linux/lists.py')
0 files changed, 0 insertions, 0 deletions