aboutsummaryrefslogtreecommitdiff
path: root/scripts/gcc-plugins
diff options
context:
space:
mode:
authorDaniel Vetter <[email protected]>2019-05-28 11:02:58 +0200
committerDaniel Vetter <[email protected]>2019-06-12 20:30:11 +0200
commitc428f35adf0faac11e0cceb7dadf3b29055d7d49 (patch)
tree5d280938631c15247eb59b4ebb143fd87928b643 /scripts/gcc-plugins
parent3667617347ba42c85ec846a9ea5c33f5d6ab9e4a (diff)
fb: Flatten control flow in fb_set_var
Instead of wiring almost everything down to the very last line using goto soup (but not consistently, where would the fun be otherwise) drop out early when checks fail. This allows us to flatten the huge indent levels to just 1. Aside: If a driver doesn't set ->fb_check_var, then FB_ACTIVATE_NOW does nothing. This bug exists ever since this code was extracted as a common helper in 2002, hence I decided against fixing it. Everyone just better have a fb_check_var to make sure things work correctly. Signed-off-by: Daniel Vetter <[email protected]> Reviewed-by: Sam Ravnborg <[email protected]> Reviewed-by: Maarten Lankhorst <[email protected]> Cc: Daniel Vetter <[email protected]> Cc: Bartlomiej Zolnierkiewicz <[email protected]> Cc: "Michał Mirosław" <[email protected]> Cc: Peter Rosin <[email protected]> Cc: Hans de Goede <[email protected]> Cc: Mikulas Patocka <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
Diffstat (limited to 'scripts/gcc-plugins')
0 files changed, 0 insertions, 0 deletions