diff options
author | Stanislav Fomichev <[email protected]> | 2019-12-04 11:09:55 -0800 |
---|---|---|
committer | Alexei Starovoitov <[email protected]> | 2019-12-04 18:01:05 -0800 |
commit | ef8c84effce3c7a0b8196fcda8f430c815ab511c (patch) | |
tree | 10cc86cc9c2f54f8bf93c7e8f6da1ccfafa6c719 /scripts/gcc-plugins/cyc_complexity_plugin.c | |
parent | 6bf6affe18dafea6ef12036001162ac7f2dbf738 (diff) |
selftests/bpf: De-flake test_tcpbpf
It looks like BPF program that handles BPF_SOCK_OPS_STATE_CB state
can race with the bpf_map_lookup_elem("global_map"); I sometimes
see the failures in this test and re-running helps.
Since we know that we expect the callback to be called 3 times (one
time for listener socket, two times for both ends of the connection),
let's export this number and add simple retry logic around that.
Also, let's make EXPECT_EQ() not return on failure, but continue
evaluating all conditions; that should make potential debugging
easier.
With this fix in place I don't observe the flakiness anymore.
Signed-off-by: Stanislav Fomichev <[email protected]>
Signed-off-by: Alexei Starovoitov <[email protected]>
Cc: Lawrence Brakmo <[email protected]>
Link: https://lore.kernel.org/bpf/[email protected]
Diffstat (limited to 'scripts/gcc-plugins/cyc_complexity_plugin.c')
0 files changed, 0 insertions, 0 deletions