diff options
| author | Jakub Sitnicki <[email protected]> | 2020-03-17 18:04:39 +0100 |
|---|---|---|
| committer | David S. Miller <[email protected]> | 2020-03-21 20:08:17 -0700 |
| commit | d5bee7374b68de3c44586d46e9e61ffc97a1e886 (patch) | |
| tree | 9c1964e017b681e310c7ec48352bd124da90930c /scripts/gcc-plugins/cyc_complexity_plugin.c | |
| parent | 5bb4c45d466cb28dd0a7f15f80c4cb7768054e94 (diff) | |
net/tls: Annotate access to sk_prot with READ_ONCE/WRITE_ONCE
sockmap performs lockless writes to sk->sk_prot on the following paths:
tcp_bpf_{recvmsg|sendmsg} / sock_map_unref
sk_psock_put
sk_psock_drop
sk_psock_restore_proto
WRITE_ONCE(sk->sk_prot, proto)
To prevent load/store tearing [1], and to make tooling aware of intentional
shared access [2], we need to annotate other sites that access sk_prot with
READ_ONCE/WRITE_ONCE macros.
Change done with Coccinelle with following semantic patch:
@@
expression E;
identifier I;
struct sock *sk;
identifier sk_prot =~ "^sk_prot$";
@@
(
E =
-sk->sk_prot
+READ_ONCE(sk->sk_prot)
|
-sk->sk_prot = E
+WRITE_ONCE(sk->sk_prot, E)
|
-sk->sk_prot
+READ_ONCE(sk->sk_prot)
->I
)
Signed-off-by: Jakub Sitnicki <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'scripts/gcc-plugins/cyc_complexity_plugin.c')
0 files changed, 0 insertions, 0 deletions