diff options
| author | Paolo Abeni <[email protected]> | 2021-05-27 16:31:37 -0700 |
|---|---|---|
| committer | Jakub Kicinski <[email protected]> | 2021-05-28 13:51:39 -0700 |
| commit | b5941f066b4ca331db225a976dae1d6ca8cf0ae3 (patch) | |
| tree | b6fa9bcf8c7680ae478f77f611f2fcf94df7cc13 /scripts/gcc-plugins/cyc_complexity_plugin.c | |
| parent | 44991d61aa120ed3e12f75bb0e0fbd2a84df930d (diff) | |
mptcp: fix sk_forward_memory corruption on retransmission
MPTCP sk_forward_memory handling is a bit special, as such field
is protected by the msk socket spin_lock, instead of the plain
socket lock.
Currently we have a code path updating such field without handling
the relevant lock:
__mptcp_retrans() -> __mptcp_clean_una_wakeup()
Several helpers in __mptcp_clean_una_wakeup() will update
sk_forward_alloc, possibly causing such field corruption, as reported
by Matthieu.
Address the issue providing and using a new variant of blamed function
which explicitly acquires the msk spin lock.
Fixes: 64b9cea7a0af ("mptcp: fix spurious retransmissions")
Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/172
Reported-by: Matthieu Baerts <[email protected]>
Tested-by: Matthieu Baerts <[email protected]>
Signed-off-by: Paolo Abeni <[email protected]>
Signed-off-by: Mat Martineau <[email protected]>
Signed-off-by: Jakub Kicinski <[email protected]>
Diffstat (limited to 'scripts/gcc-plugins/cyc_complexity_plugin.c')
0 files changed, 0 insertions, 0 deletions