diff options
author | Huy Nguyen <[email protected]> | 2020-06-01 16:39:37 -0500 |
---|---|---|
committer | Steffen Klassert <[email protected]> | 2020-06-04 10:45:14 +0200 |
commit | 94579ac3f6d0820adc83b5dc5358ead0158101e9 (patch) | |
tree | 993e23a70e70df318f25b6b7d8e80509e623fa21 /scripts/gcc-plugins/cyc_complexity_plugin.c | |
parent | cb8e59cc87201af93dfbb6c3dccc8fcad72a09c2 (diff) |
xfrm: Fix double ESP trailer insertion in IPsec crypto offload.
During IPsec performance testing, we see bad ICMP checksum. The error packet
has duplicated ESP trailer due to double validate_xmit_xfrm calls. The first call
is from ip_output, but the packet cannot be sent because
netif_xmit_frozen_or_stopped is true and the packet gets dev_requeue_skb. The second
call is from NET_TX softirq. However after the first call, the packet already
has the ESP trailer.
Fix by marking the skb with XFRM_XMIT bit after the packet is handled by
validate_xmit_xfrm to avoid duplicate ESP trailer insertion.
Fixes: f6e27114a60a ("net: Add a xfrm validate function to validate_xmit_skb")
Signed-off-by: Huy Nguyen <[email protected]>
Reviewed-by: Boris Pismenny <[email protected]>
Reviewed-by: Raed Salem <[email protected]>
Reviewed-by: Saeed Mahameed <[email protected]>
Signed-off-by: Steffen Klassert <[email protected]>
Diffstat (limited to 'scripts/gcc-plugins/cyc_complexity_plugin.c')
0 files changed, 0 insertions, 0 deletions