aboutsummaryrefslogtreecommitdiff
path: root/scripts/gcc-plugins/cyc_complexity_plugin.c
diff options
context:
space:
mode:
authorFlorian Vaussard <[email protected]>2016-11-29 18:10:49 +0100
committerMark Brown <[email protected]>2016-12-05 13:53:08 +0000
commit8c317fafdd4e3b988c44d986022c66cebf71fc41 (patch)
treef5f1a98d4c36b5949a2371c158efcee6c33c7f85 /scripts/gcc-plugins/cyc_complexity_plugin.c
parentda5eb41763c750d1660ca0a962f15f268821b3e6 (diff)
ASoC: cs42l56: Fix misuse of regmap_update_bits
Using regmap_update_bits(..., mask, 1) with 'mask' following (1 << k) and k greater than 0 is wrong. Indeed, _regmap_update_bits will perform (mask & 1), which results in 0 if LSB of mask is 0. Thus the call regmap_update_bits(..., mask, 1) is in reality equivalent to regmap_update_bits(..., mask, 0). In such a case, the correct use is regmap_update_bits(..., mask, mask). This driver is performing such a mistake with the CS42L56_AIN*_REF_MASK masks, which equal 0x10, 0x20, 0x40 and 0x80. Fix the driver to make it consistent with the API. Please note that this change is untested, as I do not have this piece of hardware. Testers are welcome! Signed-off-by: Florian Vaussard <[email protected]> Reviewed-by: Charles Keepax <[email protected]> Acked-by: Brian Austin <[email protected]> Signed-off-by: Mark Brown <[email protected]>
Diffstat (limited to 'scripts/gcc-plugins/cyc_complexity_plugin.c')
0 files changed, 0 insertions, 0 deletions