diff options
author | Lihong Kou <[email protected]> | 2021-09-14 09:06:56 +0200 |
---|---|---|
committer | Jens Axboe <[email protected]> | 2021-09-14 20:03:30 -0600 |
commit | 3df49967f6f1d2121b0c27c381ca1c8386b1dab9 (patch) | |
tree | 5f6e187a491835514d8960b668085b945f0686be /scripts/gcc-plugins/cyc_complexity_plugin.c | |
parent | 783a40a1b3ac7f3714d2776fa8ac8cce3535e4f6 (diff) |
block: flush the integrity workqueue in blk_integrity_unregister
When the integrity profile is unregistered there can still be integrity
reads queued up which could see a NULL verify_fn as shown by the race
window below:
CPU0 CPU1
process_one_work nvme_validate_ns
bio_integrity_verify_fn nvme_update_ns_info
nvme_update_disk_info
blk_integrity_unregister
---set queue->integrity as 0
bio_integrity_process
--access bi->profile->verify_fn(bi is a pointer of queue->integity)
Before calling blk_integrity_unregister in nvme_update_disk_info, we must
make sure that there is no work item in the kintegrityd_wq. Just call
blk_flush_integrity to flush the work queue so the bug can be resolved.
Signed-off-by: Lihong Kou <[email protected]>
[hch: split up and shortened the changelog]
Signed-off-by: Christoph Hellwig <[email protected]>
Reviewed-by: Sagi Grimberg <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jens Axboe <[email protected]>
Diffstat (limited to 'scripts/gcc-plugins/cyc_complexity_plugin.c')
0 files changed, 0 insertions, 0 deletions