diff options
author | Eric Saint-Etienne <[email protected]> | 2018-11-21 09:51:19 -0800 |
---|---|---|
committer | Arnaldo Carvalho de Melo <[email protected]> | 2018-11-21 22:39:59 -0300 |
commit | 1e6285699b3034e6f4d1f091edd46d717580bf7c (patch) | |
tree | c0416336b99ae705566d20091d472337d6bda7f8 /scripts/gcc-plugins/cyc_complexity_plugin.c | |
parent | dd1d0044dd1c1bf84a9b3e1f24e43347b26b96a0 (diff) |
perf symbols: Fix slowness due to -ffunction-section
Perf can take minutes to parse an image when -ffunction-section is used.
This is especially true with the kernel image when it is compiled this
way, which is the arm64 default since the patcheset "Enable deadcode
elimination at link time".
Perf organize maps using a rbtree. Whenever perf finds a new symbols, it
first searches this rbtree for the map it belongs to, by strcmp()'aring
section names. When it finds the map with the right name, it uses it to
add the symbol. With a usual image there aren't so many maps but when
using -ffunction-section there's basically one map per function. With
the kernel image that's north of 40,000 maps. For most symbols perf has
to parses the entire rbtree to eventually create a new map and add it.
Consequently perf spends most of the time browsing a rbtree that keeps
getting larger.
This performance fix introduces a secondary rbtree that indexes maps
based on the section name.
Signed-off-by: Eric Saint-Etienne <[email protected]>
Reviewed-by: Dave Kleikamp <[email protected]>
Reviewed-by: David Aldridge <[email protected]>
Reviewed-by: Rob Gardner <[email protected]>
Cc: Alexander Shishkin <[email protected]>
Cc: Jiri Olsa <[email protected]>
Cc: Namhyung Kim <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
Diffstat (limited to 'scripts/gcc-plugins/cyc_complexity_plugin.c')
0 files changed, 0 insertions, 0 deletions