diff options
| author | Dan Carpenter <[email protected]> | 2020-11-13 13:12:41 +0300 |
|---|---|---|
| committer | Takashi Iwai <[email protected]> | 2020-11-13 18:37:22 +0100 |
| commit | 02a9c6ee4183af2e438454c55098b828a96085fb (patch) | |
| tree | b3b8ec8748d4255fb458a8f7be991caf5b3d219b /scripts/gcc-plugins/cyc_complexity_plugin.c | |
| parent | 95a793c3bc75cf888e0e641d656e7d080f487d8b (diff) | |
ALSA: firewire: Clean up a locking issue in copy_resp_to_buf()
The spin_lock/unlock_irq() functions cannot be nested. The problem is
that presumably we would want the IRQs to be re-enabled on the second
call the spin_unlock_irq() but instead it will be enabled at the first
call so IRQs will be enabled earlier than expected.
In this situation the copy_resp_to_buf() function is only called from
one function and it is called with IRQs disabled. We can just use
the regular spin_lock/unlock() functions.
Fixes: 555e8a8f7f14 ("ALSA: fireworks: Add command/response functionality into hwdep interface")
Signed-off-by: Dan Carpenter <[email protected]>
Acked-by: Takashi Sakamoto <[email protected]>
Cc: <[email protected]>
Link: https://lore.kernel.org/r/20201113101241.GB168908@mwanda
Signed-off-by: Takashi Iwai <[email protected]>
Diffstat (limited to 'scripts/gcc-plugins/cyc_complexity_plugin.c')
0 files changed, 0 insertions, 0 deletions