aboutsummaryrefslogtreecommitdiff
path: root/scripts/decodecode
diff options
context:
space:
mode:
authorFabio M. De Francesco <[email protected]>2022-08-09 22:31:05 +0200
committerAndrew Morton <[email protected]>2022-09-11 21:55:05 -0700
commit9f25f357c557bfea39a2d6a629a6317d2b3dfc64 (patch)
tree5a1a5ae4f2a31d69e6a672c4c0314e467b64ca22 /scripts/decodecode
parentf9ef3b95a305874de0b36b7294f6cc8a0e07951e (diff)
hfsplus: convert kmap() to kmap_local_page() in btree.c
kmap() is being deprecated in favor of kmap_local_page(). There are two main problems with kmap(): (1) It comes with an overhead as mapping space is restricted and protected by a global lock for synchronization and (2) it also requires global TLB invalidation when the kmap's pool wraps and it might block when the mapping space is fully utilized until a slot becomes available. With kmap_local_page() the mappings are per thread, CPU local, can take page faults, and can be called from any context (including interrupts). It is faster than kmap() in kernels with HIGHMEM enabled. Furthermore, the tasks can be preempted and, when they are scheduled to run again, the kernel virtual addresses are restored and are still valid. Since its use in btree.c is safe everywhere, it should be preferred. Therefore, replace kmap() with kmap_local_page() in btree.c. Tested in a QEMU/KVM x86_32 VM, 6GB RAM, booting a kernel with HIGHMEM64GB enabled. Link: https://lkml.kernel.org/r/[email protected] Signed-off-by: Fabio M. De Francesco <[email protected]> Suggested-by: Ira Weiny <[email protected]> Reviewed-by: Ira Weiny <[email protected]> Reviewed-by: Viacheslav Dubeyko <[email protected]> Cc: Bart Van Assche <[email protected]> Cc: Jens Axboe <[email protected]> Cc: Kees Cook <[email protected]> Cc: Matthew Wilcox <[email protected]> Cc: Muchun Song <[email protected]> Signed-off-by: Andrew Morton <[email protected]>
Diffstat (limited to 'scripts/decodecode')
0 files changed, 0 insertions, 0 deletions