diff options
author | Niels Dossche <[email protected]> | 2022-04-09 13:12:43 +0900 |
---|---|---|
committer | Takashi Iwai <[email protected]> | 2022-04-25 08:01:09 +0200 |
commit | a7ecbe92b9243edbe94772f6f2c854e4142a3345 (patch) | |
tree | 2fae7ac5c9b99acffb048c43e0612579ec166484 /scripts/bpf_doc.py | |
parent | 9423973869bd4632ffe669f950510c49296656e0 (diff) |
firewire: core: extend card->lock in fw_core_handle_bus_reset
card->local_node and card->bm_retries are both always accessed under
card->lock.
fw_core_handle_bus_reset has a check whose condition depends on
card->local_node and whose body writes to card->bm_retries.
Both of these accesses are not under card->lock. Move the lock acquiring
of card->lock to before this check such that these accesses do happen
when card->lock is held.
fw_destroy_nodes is called inside the check.
Since fw_destroy_nodes already acquires card->lock inside its function
body, move this out to the callsites of fw_destroy_nodes.
Also add a comment to indicate which locking is necessary when calling
fw_destroy_nodes.
Cc: <[email protected]>
Signed-off-by: Niels Dossche <[email protected]>
Signed-off-by: Takashi Sakamoto <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Takashi Iwai <[email protected]>
Diffstat (limited to 'scripts/bpf_doc.py')
0 files changed, 0 insertions, 0 deletions