diff options
| author | Andrew Morton <[email protected]> | 2006-06-29 02:24:26 -0700 |
|---|---|---|
| committer | Linus Torvalds <[email protected]> | 2006-06-29 10:26:20 -0700 |
| commit | 81b0c8713385ce1b1b9058e916edcf9561ad76d6 (patch) | |
| tree | 4c5e8fde3d15503c609d5c5f74911f95fc528f03 /scripts/basic/split-include.c | |
| parent | 0686cd8fbe3e5fb1441ae84b9cbc813f9297b879 (diff) | |
[PATCH] generic_file_buffered_write(): handle zero-length iovec segments
The recent generic_file_write() deadlock fix caused
generic_file_buffered_write() to loop inifinitely when presented with a
zero-length iovec segment. Fix.
Note that this fix deliberately avoids calling ->prepare_write(),
->commit_write() etc with a zero-length write. This is because I don't trust
all filesystems to get that right.
This is a cautious approach, for 2.6.17.x. For 2.6.18 we should just go ahead
and call ->prepare_write() and ->commit_write() with the zero length and fix
any broken filesystems. So I'll make that change once this code is stabilised
and backported into 2.6.17.x.
The reason for preferring to call ->prepare_write() and ->commit_write() with
the zero-length segment: a zero-length segment _should_ be sufficiently
uncommon that this is the correct way of handling it. We don't want to
optimise for poorly-written userspace at the expense of well-written
userspace.
Cc: "Vladimir V. Saveliev" <[email protected]>
Cc: Neil Brown <[email protected]>
Cc: Martin Schwidefsky <[email protected]>
Cc: Chris Wright <[email protected]>
Cc: Greg KH <[email protected]>
Cc: <[email protected]>
Cc: walt <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
Diffstat (limited to 'scripts/basic/split-include.c')
0 files changed, 0 insertions, 0 deletions