diff options
| author | Justin Stitt <[email protected]> | 2023-09-13 20:23:02 +0000 |
|---|---|---|
| committer | Nishanth Menon <[email protected]> | 2023-09-20 07:52:08 -0500 |
| commit | d8cce0d5ba4a3157a7a549b9623d1ffc5820ef92 (patch) | |
| tree | 1535d303b081d3c3ddb1c4e878cd680559b8be89 /rust/helpers/helpers.c | |
| parent | be6d43efb12455dbf85c96ff67582a463d34a0fc (diff) | |
firmware: ti_sci: refactor deprecated strncpy
`strncpy` is deprecated for use on NUL-terminated destination strings [1].
We should prefer more robust and less ambiguous string interfaces.
A suitable replacement is `strscpy` [2] due to the fact that it guarantees
NUL-termination on the destination buffer.
It does not seem like `ver->firmware_description` requires NUL-padding
(which is a behavior that strncpy provides) but if it does let's opt for
`strscpy_pad()`.
Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1]
Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2]
Link: https://github.com/KSPP/linux/issues/90
Cc: [email protected]
Signed-off-by: Justin Stitt <[email protected]>
Reviewed-by: Kees Cook <[email protected]>
Link: https://lore.kernel.org/r/20230913-strncpy-drivers-firmware-ti_sci-c-v1-1-740db471110d@google.com
Signed-off-by: Nishanth Menon <[email protected]>
Diffstat (limited to 'rust/helpers/helpers.c')
0 files changed, 0 insertions, 0 deletions