diff options
| author | Jeff Layton <[email protected]> | 2023-07-21 10:29:11 -0400 |
|---|---|---|
| committer | Chuck Lever <[email protected]> | 2023-08-29 17:45:22 -0400 |
| commit | 976626073a7502fc91416155bd037a29deee729b (patch) | |
| tree | dee00efb9e7aad4a9446391ebbc78c413585a299 /rust/helpers/helpers.c | |
| parent | a332018a91c419a9a475c41d827544c771986876 (diff) | |
nfsd: remove unsafe BUG_ON from set_change_info
At one time, nfsd would scrape inode information directly out of struct
inode in order to populate the change_info4. At that time, the BUG_ON in
set_change_info made some sense, since having it unset meant a coding
error.
More recently, it calls vfs_getattr to get this information, which can
fail. If that fails, fh_pre_saved can end up not being set. While this
situation is unfortunate, we don't need to crash the box.
Move set_change_info to nfs4proc.c since all of the callers are there.
Revise the condition for setting "atomic" to also check for
fh_pre_saved. Drop the BUG_ON and just have it zero out both
change_attr4s when this occurs.
Reported-by: Boyang Xue <[email protected]>
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2223560
Signed-off-by: Jeff Layton <[email protected]>
Signed-off-by: Chuck Lever <[email protected]>
Diffstat (limited to 'rust/helpers/helpers.c')
0 files changed, 0 insertions, 0 deletions