diff options
author | Matthew Mirvish <[email protected]> | 2024-05-09 09:11:17 +0800 |
---|---|---|
committer | Jens Axboe <[email protected]> | 2024-05-08 19:15:01 -0600 |
commit | 3a861560ccb35f2a4f0a4b8207fa7c2a35fc7f31 (patch) | |
tree | abaed8a75822748de1e372b1ae2a828a8545468d /rust/helpers/helpers.c | |
parent | 2abd9a197d828ed5c2cbe922368eb28d02861a28 (diff) |
bcache: fix variable length array abuse in btree_iter
btree_iter is used in two ways: either allocated on the stack with a
fixed size MAX_BSETS, or from a mempool with a dynamic size based on the
specific cache set. Previously, the struct had a fixed-length array of
size MAX_BSETS which was indexed out-of-bounds for the dynamically-sized
iterators, which causes UBSAN to complain.
This patch uses the same approach as in bcachefs's sort_iter and splits
the iterator into a btree_iter with a flexible array member and a
btree_iter_stack which embeds a btree_iter as well as a fixed-length
data array.
Cc: [email protected]
Closes: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2039368
Signed-off-by: Matthew Mirvish <[email protected]>
Signed-off-by: Coly Li <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jens Axboe <[email protected]>
Diffstat (limited to 'rust/helpers/helpers.c')
0 files changed, 0 insertions, 0 deletions