diff options
author | Bjorn Andersson <[email protected]> | 2021-05-15 21:09:53 -0700 |
---|---|---|
committer | Greg Kroah-Hartman <[email protected]> | 2021-05-21 14:27:25 +0200 |
commit | 8c9b3caab3ac26db1da00b8117901640c55a69dd (patch) | |
tree | d600f11d9877baf7938a4b7aa9c039c7f86bb531 /net | |
parent | acf5631c239dfc53489f739c4ad47f490c5181ff (diff) |
usb: typec: ucsi: Clear pending after acking connector change
It's possible that the interrupt handler for the UCSI driver signals a
connector changes after the handler clears the PENDING bit, but before
it has sent the acknowledge request. The result is that the handler is
invoked yet again, to ack the same connector change.
At least some versions of the Qualcomm UCSI firmware will not handle the
second - "spurious" - acknowledgment gracefully. So make sure to not
clear the pending flag until the change is acknowledged.
Any connector changes coming in after the acknowledgment, that would
have the pending flag incorrectly cleared, would afaict be covered by
the subsequent connector status check.
Fixes: 217504a05532 ("usb: typec: ucsi: Work around PPM losing change information")
Cc: stable <[email protected]>
Reviewed-by: Heikki Krogerus <[email protected]>
Acked-By: Benjamin Berg <[email protected]>
Signed-off-by: Bjorn Andersson <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions