diff options
author | Thiago Rafael Becker <[email protected]> | 2017-12-14 15:33:12 -0800 |
---|---|---|
committer | Linus Torvalds <[email protected]> | 2017-12-14 16:00:49 -0800 |
commit | bdcf0a423ea1c40bbb40e7ee483b50fc8aa3d758 (patch) | |
tree | 942b1b8fa9b1e52503d5f9894d43674255813566 /net/unix/sysctl_net_unix.c | |
parent | 1f704fd0d14043e76e80f6b8b2251b9b2cedcca6 (diff) |
kernel: make groups_sort calling a responsibility group_info allocators
In testing, we found that nfsd threads may call set_groups in parallel
for the same entry cached in auth.unix.gid, racing in the call of
groups_sort, corrupting the groups for that entry and leading to
permission denials for the client.
This patch:
- Make groups_sort globally visible.
- Move the call to groups_sort to the modifiers of group_info
- Remove the call to groups_sort from set_groups
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Thiago Rafael Becker <[email protected]>
Reviewed-by: Matthew Wilcox <[email protected]>
Reviewed-by: NeilBrown <[email protected]>
Acked-by: "J. Bruce Fields" <[email protected]>
Cc: Al Viro <[email protected]>
Cc: Martin Schwidefsky <[email protected]>
Cc: <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
Diffstat (limited to 'net/unix/sysctl_net_unix.c')
0 files changed, 0 insertions, 0 deletions