diff options
| author | Michael S. Tsirkin <[email protected]> | 2015-03-10 11:55:08 +1030 |
|---|---|---|
| committer | Rusty Russell <[email protected]> | 2015-03-10 11:56:15 +1030 |
| commit | 3d2a3774c1b046f548ebea0391a602fd5685a307 (patch) | |
| tree | b664aba0a08380007cb1ae1b53a743c65957c6bc /net/unix/sysctl_net_unix.c | |
| parent | 0fa2a56437d0b7ef5d86eef2778ad3469ca72d5a (diff) | |
virtio-balloon: do not call blocking ops when !TASK_RUNNING
virtio balloon has this code:
wait_event_interruptible(vb->config_change,
(diff = towards_target(vb)) != 0
|| vb->need_stats_update
|| kthread_should_stop()
|| freezing(current));
Which is a problem because towards_target() call might block after
wait_event_interruptible sets task state to TAST_INTERRUPTIBLE, causing
the task_struct::state collision typical of nesting of sleeping
primitives
See also http://lwn.net/Articles/628628/ or Thomas's
bug report
http://article.gmane.org/gmane.linux.kernel.virtualization/24846
for a fuller explanation.
To fix, rewrite using wait_woken.
Cc: [email protected]
Reported-by: Thomas Huth <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
Tested-by: Thomas Huth <[email protected]>
Reviewed-by: Cornelia Huck <[email protected]>
Signed-off-by: Rusty Russell <[email protected]>
Diffstat (limited to 'net/unix/sysctl_net_unix.c')
0 files changed, 0 insertions, 0 deletions