diff options
| author | Alan Stern <[email protected]> | 2010-09-21 15:01:53 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <[email protected]> | 2010-09-24 11:05:00 -0700 |
| commit | 0026e00523a85b90a92a93ddf6660939ecef3e54 (patch) | |
| tree | d618b4eb0948c061256346410a4107a526aaab40 /net/unix/sysctl_net_unix.c | |
| parent | a850ea30374ebed32a0724742601861853fde869 (diff) | |
USB: fix bug in initialization of interface minor numbers
Recent changes in the usbhid layer exposed a bug in usbcore. If
CONFIG_USB_DYNAMIC_MINORS is enabled then an interface may be assigned
a minor number of 0. However interfaces that aren't registered as USB
class devices also have their minor number set to 0, during
initialization. As a result usb_find_interface() may return the
wrong interface, leading to a crash.
This patch (as1418) fixes the problem by initializing every
interface's minor number to -1. It also cleans up the
usb_register_dev() function, which besides being somewhat awkwardly
written, does not unwind completely on all its error paths.
Signed-off-by: Alan Stern <[email protected]>
Tested-by: Philip J. Turmel <[email protected]>
Tested-by: Gabriel Craciunescu <[email protected]>
Tested-by: Alex Riesen <[email protected]>
Tested-by: Matthias Bayer <[email protected]>
CC: Jiri Kosina <[email protected]>
Cc: stable <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Diffstat (limited to 'net/unix/sysctl_net_unix.c')
0 files changed, 0 insertions, 0 deletions