diff options
author | Lorenz Bauer <[email protected]> | 2020-10-12 11:18:50 +0200 |
---|---|---|
committer | Daniel Borkmann <[email protected]> | 2020-10-15 20:49:56 +0200 |
commit | f58423aeab28f861b67933206f322f764f05787d (patch) | |
tree | eb606d94e8041a53fea006c6db698f0d1788c1b3 /net/unix/scm.c | |
parent | e688c3db7ca69bea1872c5706aec6a7fdf89df17 (diff) |
bpf, sockmap: Add locking annotations to iterator
The sparse checker currently outputs the following warnings:
include/linux/rcupdate.h:632:9: sparse: sparse: context imbalance in 'sock_hash_seq_start' - wrong count at exit
include/linux/rcupdate.h:632:9: sparse: sparse: context imbalance in 'sock_map_seq_start' - wrong count at exit
Add the necessary __acquires and __release annotations to make the
iterator locking schema palatable to sparse. Also add __must_hold
for good measure.
The kernel codebase uses both __acquires(rcu) and __acquires(RCU).
I couldn't find any guidance which one is preferred, so I used
what is easier to type out.
Fixes: 0365351524d7 ("net: Allow iterating sockmap and sockhash")
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Lorenz Bauer <[email protected]>
Signed-off-by: Daniel Borkmann <[email protected]>
Acked-by: John Fastabend <[email protected]>
Acked-by: Jakub Sitnicki <[email protected]>
Link: https://lore.kernel.org/bpf/[email protected]
Diffstat (limited to 'net/unix/scm.c')
0 files changed, 0 insertions, 0 deletions