diff options
author | Aleksey Makarov <[email protected]> | 2017-04-05 23:20:00 +0300 |
---|---|---|
committer | Petr Mladek <[email protected]> | 2017-04-12 11:40:22 +0200 |
commit | cf39bf58afdaabc0b86f141630fb3fd18190294e (patch) | |
tree | 299a204a7447f5c84cdd1de0588b5e892c117cdd /net/unix/af_unix.c | |
parent | ad86ee2b8a47590f62a4f3bc1d25dc126d121cb9 (diff) |
printk: fix double printing with earlycon
If a console was specified by ACPI SPCR table _and_ command line
parameters like "console=ttyAMA0" _and_ "earlycon" were specified,
then log messages appear twice.
The root cause is that the code traverses the list of specified
consoles (the `console_cmdline` array) and stops at the first match.
But it may happen that the same console is referred by the elements
of this array twice:
pl011,mmio,0x87e024000000,115200 -- from SPCR
ttyAMA0 -- from command line
but in this case `preferred_console` points to the second entry and
the flag CON_CONSDEV is not set, so bootconsole is not deregistered.
To fix that, introduce an invariant "The last non-braille console
is always the preferred one" on the entries of the console_cmdline
array. Then traverse it in reverse order to be sure that if
the console is preferred then it will be the first matching entry.
Introduce variable console_cmdline_cnt that keeps the number
of elements of the console_cmdline array (Petr Mladek). It helps
to get rid of the loop that searches for the end of this array.
Link: http://lkml.kernel.org/r/[email protected]
Cc: Steven Rostedt <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Peter Hurley <[email protected]>
Cc: Jiri Slaby <[email protected]>
Cc: Robin Murphy <[email protected]>
Cc: "Nair, Jayachandran" <[email protected]>
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Aleksey Makarov <[email protected]>
Reported-by: Sudeep Holla <[email protected]>
Acked-by: Sergey Senozhatsky <[email protected]>
Signed-off-by: Petr Mladek <[email protected]>
Diffstat (limited to 'net/unix/af_unix.c')
0 files changed, 0 insertions, 0 deletions