diff options
| author | Jayamohan Kallickal <[email protected]> | 2014-05-05 21:41:28 -0400 |
|---|---|---|
| committer | Christoph Hellwig <[email protected]> | 2014-05-28 18:13:16 +0200 |
| commit | 8fc01eaa8793b7c2277b4a84c218a5f8fe45ccdd (patch) | |
| tree | 5713c06f874403c0816b2c23e219cb60c3973668 /net/unix/af_unix.c | |
| parent | b3c202dc57607174468b3ea6b4220b7ca5643f05 (diff) | |
be2iscsi: Fix memory corruption in MBX path
From: Dan Carpenter [mailto:[email protected]]
Sent: Friday, March 28, 2014 1:42 AM
Subject: re: [SCSI] be2iscsi: Fix handling timed out MBX completion from FW
Hello Jayamohan Kallickal,
The patch 1957aa7f6246: "[SCSI] be2iscsi: Fix handling timed out MBX completion from FW" from Jan 29, 2014, leads to the following static checker warning:
drivers/scsi/be2iscsi/be_main.c:5581 beiscsi_dev_probe()
error: memset() '&phba->ctrl.ptag_state[i]->tag_mem_state' too small (24 vs 32)
drivers/scsi/be2iscsi/be_main.c
5576 for (i = 0; i < MAX_MCC_CMD; i++) {
5577 init_waitqueue_head(&phba->ctrl.mcc_wait[i + 1]);
5578 phba->ctrl.mcc_tag[i] = i + 1;
5579 phba->ctrl.mcc_numtag[i + 1] = 0;
5580 phba->ctrl.mcc_tag_available++;
5581 memset(&phba->ctrl.ptag_state[i].tag_mem_state, 0,
5582 sizeof(struct beiscsi_mcc_tag_state));
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Probably this this be change to sizeof(struct be_dma_mem struct)? It looks like we are corrupting memory a bit here.
5583 }
regards,
dan carpenter
Reported-by: Dan Carpenter <[email protected]>
Signed-off-by: John Soni Jose <[email protected]>
Signed-off-by: Jayamohan Kallickal <[email protected]>
Signed-off-by: Christoph Hellwig <[email protected]>
Diffstat (limited to 'net/unix/af_unix.c')
0 files changed, 0 insertions, 0 deletions