diff options
| author | Sukadev Bhattiprolu <[email protected]> | 2009-05-14 19:38:24 -0700 |
|---|---|---|
| committer | Linus Torvalds <[email protected]> | 2009-05-15 08:03:23 -0700 |
| commit | 1f71ebedb3f8ce9108978168759c8551d873a912 (patch) | |
| tree | 604f633fa092872f8b70873780c36e024de3677a /net/unix/af_unix.c | |
| parent | bd67ce0f661482bd073f94144dd7e5a093ef012f (diff) | |
devpts: correctly set default options
devpts_get_sb() calls memset(0) to clear mount options and calls
parse_mount_options() if user specified any mount options.
The memset(0) is bogus since the 'mode' and 'ptmxmode' options are
non-zero by default. parse_mount_options() restores options to default
anyway and can properly deal with NULL mount options.
So in devpts_get_sb() remove memset(0) and call parse_mount_options() even
for NULL mount options.
Bug reported by Eric Paris: http://lkml.org/lkml/2009/5/7/448.
Signed-off-by: Sukadev Bhattiprolu <[email protected]>
Tested-by: Marc Dionne <[email protected]>
Reported-by: Eric Paris <[email protected]>
Cc: Christoph Hellwig <[email protected]>
Cc: Alan Cox <[email protected]>
Acked-by: Serge Hallyn <[email protected]>
Cc: Al Viro <[email protected]>
Cc: "Rafael J. Wysocki" <[email protected]>
Reviewed-by: "H. Peter Anvin" <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
Diffstat (limited to 'net/unix/af_unix.c')
0 files changed, 0 insertions, 0 deletions