diff options
| author | Heiko Carstens <[email protected]> | 2017-03-27 09:48:04 +0200 |
|---|---|---|
| committer | Martin Schwidefsky <[email protected]> | 2017-03-30 08:18:59 +0200 |
| commit | d09c5373e8e4eaaa09233552cbf75dc4c4f21203 (patch) | |
| tree | 6bb8d0f317d621a46e39ef5a9883a22559a5c7af /net/lapb | |
| parent | ca681ec860d6533b8debda4f6ab2e70e6d519d89 (diff) | |
s390/uaccess: get_user() should zero on failure (again)
Commit fd2d2b191fe7 ("s390: get_user() should zero on failure")
intended to fix s390's get_user() implementation which did not zero
the target operand if the read from user space faulted. Unfortunately
the patch has no effect: the corresponding inline assembly specifies
that the operand is only written to ("=") and the previous value is
discarded.
Therefore the compiler is free to and actually does omit the zero
initialization.
To fix this simply change the contraint modifier to "+", so the
compiler cannot omit the initialization anymore.
Fixes: c9ca78415ac1 ("s390/uaccess: provide inline variants of get_user/put_user")
Fixes: fd2d2b191fe7 ("s390: get_user() should zero on failure")
Cc: [email protected]
Cc: Al Viro <[email protected]>
Signed-off-by: Heiko Carstens <[email protected]>
Signed-off-by: Martin Schwidefsky <[email protected]>
Diffstat (limited to 'net/lapb')
0 files changed, 0 insertions, 0 deletions