aboutsummaryrefslogtreecommitdiff
path: root/net/lapb
diff options
context:
space:
mode:
authorGuenter Roeck <[email protected]>2018-09-13 20:30:10 -0700
committerWolfram Sang <[email protected]>2018-09-24 23:44:33 +0200
commit2be6b47211e17e6c90ead40d24d2a5cc815f2d5c (patch)
treec930c3c61c144056861b8869c8a65ea60f743022 /net/lapb
parent3e9efc3299dd78a0fa96515f0a453fab1ed4a1bd (diff)
i2c: aspeed: Acknowledge most interrupts early in interrupt handler
Commit 3e9efc3299dd ("i2c: aspeed: Handle master/slave combined irq events properly") moved interrupt acknowledgment to the end of the interrupt handler. In part this was done because the AST2500 datasheet says: I2CD10 Interrupt Status Register bit 2 Receive Done Interrupt status S/W needs to clear this status bit to allow next data receiving. Acknowledging Receive Done before receive data was handled resulted in receive errors on high speed I2C busses. However, interrupt acknowledgment was not only moved to the end of the interrupt handler for Receive Done Interrupt status, but for all interrupt status bits. This could result in race conditions if a second interrupt was received during interrupt handling and not handled but still acknowledged at the end of the interrupt handler. Acknowledge only "Receive Done Interrupt status" late in the interrupt handler to solve the problem. Fixes: 3e9efc3299dd ("i2c: aspeed: Handle master/slave combined irq events properly") Cc: Jae Hyun Yoo <[email protected]> Cc: Joel Stanley <[email protected]> Signed-off-by: Guenter Roeck <[email protected]> Acked-by: Jae Hyun Yoo <[email protected]> Tested-by: Joel Stanley <[email protected]> Acked-by: Brendan Higgins <[email protected]> Signed-off-by: Wolfram Sang <[email protected]>
Diffstat (limited to 'net/lapb')
0 files changed, 0 insertions, 0 deletions