aboutsummaryrefslogtreecommitdiff
path: root/net/lapb/lapb_timer.c
diff options
context:
space:
mode:
authorLiu Ying <[email protected]>2022-01-24 10:40:07 +0800
committerVinod Koul <[email protected]>2022-02-02 10:33:04 +0530
commit9a8406ba1a9a2965c27e0db1d7753471d12ee9ff (patch)
tree2fceeab99e34a3b57eb2f930866ff402ea2fa372 /net/lapb/lapb_timer.c
parent46e994717807f4b935c44d81dde9dd8bcd9a4f5d (diff)
phy: dphy: Correct clk_pre parameter
The D-PHY specification (v1.2) explicitly mentions that the T-CLK-PRE parameter's unit is Unit Interval(UI) and the minimum value is 8. Also, kernel doc of the 'clk_pre' member of struct phy_configure_opts_mipi_dphy mentions that it should be in UI. However, the dphy core driver wrongly sets 'clk_pre' to 8000, which seems to hint that it's in picoseconds. So, let's fix the dphy core driver to correctly reflect the T-CLK-PRE parameter's minimum value according to the D-PHY specification. I'm assuming that all impacted custom drivers shall program values in TxByteClkHS cycles into hardware for the T-CLK-PRE parameter. The D-PHY specification mentions that the frequency of TxByteClkHS is exactly 1/8 the High-Speed(HS) bit rate(each HS bit consumes one UI). So, relevant custom driver code is changed to program those values as DIV_ROUND_UP(cfg->clk_pre, BITS_PER_BYTE), then. Note that I've only tested the patch with RM67191 DSI panel on i.MX8mq EVK. Help is needed to test with other i.MX8mq, Meson and Rockchip platforms, as I don't have the hardwares. Fixes: 2ed869990e14 ("phy: Add MIPI D-PHY configuration options") Tested-by: Liu Ying <[email protected]> # RM67191 DSI panel on i.MX8mq EVK Reviewed-by: Andrzej Hajda <[email protected]> Reviewed-by: Neil Armstrong <[email protected]> # for phy-meson-axg-mipi-dphy.c Tested-by: Neil Armstrong <[email protected]> # for phy-meson-axg-mipi-dphy.c Tested-by: Guido Günther <[email protected]> # Librem 5 (imx8mq) with it's rather picky panel Reviewed-by: Laurent Pinchart <[email protected]> Signed-off-by: Liu Ying <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Vinod Koul <[email protected]>
Diffstat (limited to 'net/lapb/lapb_timer.c')
0 files changed, 0 insertions, 0 deletions