aboutsummaryrefslogtreecommitdiff
path: root/net/lapb/lapb_timer.c
diff options
context:
space:
mode:
authorGuilherme G. Piccoli <[email protected]>2021-12-21 12:52:30 -0300
committerCatalin Marinas <[email protected]>2021-12-22 11:06:11 +0000
commit31e833b2031232493f2c30e53401e1f5ba293f97 (patch)
treec56b74cc4928dd8c5f13dd3827f4681ba9227ff3 /net/lapb/lapb_timer.c
parentd5624bb29f49b849ac8d1e9783dbf9c65cf33457 (diff)
arm64: Unhash early pointer print plus improve comment
When facing a really early issue on DT parsing we have currently a message that shows both the physical and virtual address of the FDT. The printk pointer modifier for the virtual address shows a hashed address there unless the user provides "no_hash_pointers" parameter in the command-line. The situation in which this message shows-up is a bit more serious though: the boot process is broken, nothing can be done (even an oops is too much for this early stage) so we have this message as a last resort in order to help debug bootloader issues, for example. Hence, we hereby change that to "%px" in order to make debugging easy, there's not much information leak risk in such early boot failure. Also, we tried to improve a bit the commenting on that function, given that if kernel fails there, it just hangs forever in a cpu_relax() loop. The reason we cannot BUG/panic is that is too early to do so; thanks to Mark Brown for pointing that on IRC and thanks Robin Murphy for the good pointer hash discussion in the mailing-list. Cc: Mark Brown <[email protected]> Cc: Robin Murphy <[email protected]> Signed-off-by: Guilherme G. Piccoli <[email protected]> Reviewed-by: Robin Murphy <[email protected]> Acked-by: Uwe Kleine-König <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Catalin Marinas <[email protected]>
Diffstat (limited to 'net/lapb/lapb_timer.c')
0 files changed, 0 insertions, 0 deletions