aboutsummaryrefslogtreecommitdiff
path: root/net/lapb/lapb_subr.c
diff options
context:
space:
mode:
authorMichel Lespinasse <[email protected]>2011-12-19 17:12:06 -0800
committerLinus Torvalds <[email protected]>2011-12-20 10:25:04 -0800
commit3d3c8f93a237b64580c5c5e138edeb1377e98230 (patch)
tree8c932423a1c5f80320e46dc77f29c668f196d73c /net/lapb/lapb_subr.c
parent0006526d78e93c3684c806bf7cf3f67dfa49c3c8 (diff)
binary_sysctl(): fix memory leak
binary_sysctl() calls sysctl_getname() which allocates from names_cache slab usin __getname() The matching function to free the name is __putname(), and not putname() which should be used only to match getname() allocations. This is because when auditing is enabled, putname() calls audit_putname *instead* (not in addition) to __putname(). Then, if a syscall is in progress, audit_putname does not release the name - instead, it expects the name to get released when the syscall completes, but that will happen only if audit_getname() was called previously, i.e. if the name was allocated with getname() rather than the naked __getname(). So, __getname() followed by putname() ends up leaking memory. Signed-off-by: Michel Lespinasse <[email protected]> Acked-by: Al Viro <[email protected]> Cc: Christoph Hellwig <[email protected]> Cc: Eric Paris <[email protected]> Cc: <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
Diffstat (limited to 'net/lapb/lapb_subr.c')
0 files changed, 0 insertions, 0 deletions