diff options
author | Chanho Park <[email protected]> | 2022-06-27 10:38:45 +0900 |
---|---|---|
committer | Mark Brown <[email protected]> | 2022-06-27 23:26:54 +0100 |
commit | 82295bc0d192d7e35e0568b18ca66da2c3058fd5 (patch) | |
tree | 210c03b0361dcc34f39a283de8fa3b9fee0c6954 /net/lapb/lapb_out.c | |
parent | 917e43de2a56d9b82576f1cc94748261f1988458 (diff) |
spi: s3c64xx: move dma_release_channel to unprepare
This fixes the sequence of dma_release_channel.
Since commit f52b03c70744 ("spi: s3c64xx: requests spi-dma channel only
during data transfer"),
dma_release_channel has been located in the s3c64xx_spi_transfer_one
but this makes invalid return of can_dma callback.
__spi_unmap_msg will check whether the request is requested by dma or
not via can_dma callback. When it is calling to check it, the channels
will be already released at the end of s3c64xx_spi_transfer_one so the
callback function will return always "false". So, they can't be unmapped
from __spi_unmap_msg call. To fix this, we need to add
unprepare_transfer_hardware callback and move the dma_release_channel
from s3c64xx_spi_transfer_one to there.
Fixes: f52b03c70744 ("spi: s3c64xx: requests spi-dma channel only during data transfer")
Signed-off-by: Chanho Park <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
Diffstat (limited to 'net/lapb/lapb_out.c')
0 files changed, 0 insertions, 0 deletions