aboutsummaryrefslogtreecommitdiff
path: root/net/lapb/lapb_out.c
diff options
context:
space:
mode:
authorMiquel Raynal <[email protected]>2022-01-27 12:06:31 +0100
committerMiquel Raynal <[email protected]>2022-01-31 17:18:03 +0100
commit3f26d1bf90ba9bf420e49ec9cdbe13d15c0df7cd (patch)
tree5cf5dec3b435f9b286b3c862c351cc46dfb5c98e /net/lapb/lapb_out.c
parentca6263a0c9503d98b5aef04ed9b0f3971c66ec4e (diff)
mtd: Fix misuses of of_match_ptr()
of_match_ptr() either expands to NULL if !CONFIG_OF, or is transparent otherwise. There are several drivers using this macro which keep their of_device_id array enclosed within an #ifdef CONFIG_OF check, these are considered fine. However, When misused, the of_device_id array pointed by this macro will produce a warning because it is finally unused when compiled without OF support. A number of fixes are possible: - Always depend on CONFIG_OF, but this will not always work and may break boards. - Enclose the compatible array by #ifdef's, this may save a bit of memory but will reduce build coverage. - Tell the compiler the array may be unused, if this can be avoided, let's not do this. - Just drop the macro, setting the of_device_id array for a non OF enabled platform is not an issue, it will just be unused. The latter solution seems the more appropriate, so let's use it. Reported-by: kernel test robot <[email protected]> Signed-off-by: Miquel Raynal <[email protected]> Acked-by: Paul Cercueil <[email protected]> Reviewed-by: Alexandre Belloni <[email protected]> Acked-by: Pratyush Yadav <[email protected]> Link: https://lore.kernel.org/linux-mtd/[email protected]
Diffstat (limited to 'net/lapb/lapb_out.c')
0 files changed, 0 insertions, 0 deletions