diff options
author | Brian Norris <[email protected]> | 2012-05-02 10:14:55 -0700 |
---|---|---|
committer | David Woodhouse <[email protected]> | 2012-05-13 23:20:00 -0500 |
commit | 1fbb938dff5b6bb4514a4e7600276b03c7f08e25 (patch) | |
tree | 49ab8089580041bcbd767ff7a57aa7188ee6b6c0 /net/lapb/lapb_out.c | |
parent | b4f7aa84d6ff44327ab91a2973ebf0c2a7797d24 (diff) |
mtd: nand: add 'oob_required' argument to NAND {read,write}_page interfaces
New NAND controllers can perform read/write via HW engines which don't expose
OOB data in their DMA mode. To reflect this, we should rework the nand_chip /
nand_ecc_ctrl interfaces that assume that drivers will always read/write OOB
data in the nand_chip.oob_poi buffer. A better interface includes a boolean
argument that explicitly tells the callee when OOB data is requested by the
calling layer (for reading/writing to/from nand_chip.oob_poi).
This patch adds the 'oob_required' parameter to each relevant {read,write}_page
interface; all 'oob_required' parameters are left unused for now. The next
patch will set the parameter properly in the nand_base.c callers, and follow-up
patches will make use of 'oob_required' in some of the callee functions.
Note that currently, there is no harm in ignoring the 'oob_required' parameter
and *always* utilizing nand_chip.oob_poi, but there can be
performance/complexity/design benefits from avoiding filling oob_poi in the
common case. I will try to implement this for some drivers which can be ported
easily.
Note: I couldn't compile-test all of these easily, as some had ARCH
dependencies.
[dwmw2: Merge later 1/0 vs. true/false cleanup]
Signed-off-by: Brian Norris <[email protected]>
Reviewed-by: Shmulik Ladkani <[email protected]>
Acked-by: Jiandong Zheng <[email protected]>
Acked-by: Mike Dunn <[email protected]>
Signed-off-by: Artem Bityutskiy <[email protected]>
Signed-off-by: David Woodhouse <[email protected]>
Diffstat (limited to 'net/lapb/lapb_out.c')
0 files changed, 0 insertions, 0 deletions