diff options
author | Ashutosh Dixit <[email protected]> | 2013-11-27 08:58:41 -0800 |
---|---|---|
committer | Greg Kroah-Hartman <[email protected]> | 2013-11-27 11:03:38 -0800 |
commit | 1e31aa9270daab40c7aef9d5488982e3475b87ef (patch) | |
tree | b1c30376de230c4b21965622c5fc4e2705188ac5 /net/lapb/lapb_out.c | |
parent | 286c24028c7f2df637323e672d9aa54a07b67bde (diff) |
misc: mic: Fix user space namespace pollution from mic_common.h.
Avoid declaring ALIGN() and __aligned() in
include/uapi/linux/mic_common.h since they pollute user space
namespace. Also, mic_aligned_size() can be simply replaced simply by
sizeof() since all structures where mic_aligned_size() is used are
declared using __attribute__ ((aligned(8)));
--
>From mail from H Peter Anvin about this:
On Fri, Nov 08, 2013 H Peter Anvin <[email protected]> wrote:
Subject: Namespace pollution in mic_common.h
This puts two macros, ALIGN() and __aligned(), into arbitrary user space
namespace. This really isn't safe or acceptable, especially since those
symbols are highly generic.
...
When these structures are forced-aligned, they will in fact have padding
automatically added by the compiler to an 8-byte boundary anyway, so
mic_aligned_size() does nothing.
...
Reported-by: H Peter Anvin <[email protected]>
Reviewed-by: Sudeep Dutt <[email protected]>
Signed-off-by: Nikhil Rao <[email protected]>
Signed-off-by: Ashutosh Dixit <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Diffstat (limited to 'net/lapb/lapb_out.c')
0 files changed, 0 insertions, 0 deletions